Skip non-ASCII titles in list renames#17
Merged
Conversation
Previously, --script mode would silently emit a mv command for locations[0] only when a video had multiple file locations, ignoring the rest. Since the right action for multi-location entries is ambiguous, skip them entirely in script mode so the generated commands are always safe to run as-is. Output mode already shows a WARNING for these entries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Titles containing non-ASCII characters (e.g. accented letters) cannot be represented safely in filenames on most filesystems; they typically get mangled to '?' on disk. The existing '?' check only catches literal question marks in the Plex title, not this case. Add isascii() to the exclusion guard so titles like 'Ménage á Trois' are skipped rather than generating a mv command that would produce a broken filename. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ménage á Trois) get mangled to?substitutions on disk, so the title-in-location match fails and they incorrectly appear as rename candidates'?' in video.titleguard only catches literal?in the Plex title, not accented/unicode characters in the title that cause?in the filenamenot video.title.isascii()to the exclusion block — applies in both output and script modeTriggered by
/library/metadata/159156(Clemence Audiard, Candie Luciani - Ménage á Trois).Test plan
plexadm list renames "Clemence"no longer shows the Ménage á Trois entrymake lintpasses clean🤖 Generated with Claude Code